-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: create @docusaurus/bundler
and @docusaurus/babel
packages
#10511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slorber
added
the
pr: maintenance
This PR does not produce any behavior differences to end users when upgrading.
label
Sep 19, 2024
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
slorber
added
the
Argos
Add this label to run UI visual regression tests. See argos.yml GH action.
label
Sep 19, 2024
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
slorber
changed the title
refactor: improve dynamic bundler infrastructure, create
refactor: create Sep 20, 2024
@docusaurus/bundler
package@docusaurus/bundler
and @docusaurus/babel
packages
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Argos
Add this label to run UI visual regression tests. See argos.yml GH action.
CLA Signed
Signed Facebook CLA
pr: maintenance
This PR does not produce any behavior differences to end users when upgrading.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Improve the codebase in preparation for introducing opt-in Rspack support (#10402)
This also creates 2 new packages:
@docusaurus/bundler
to encapsulate bundler utils (plugins/loaders/...) under a shared abstraction so that they work for both Webpack/Rspack@docusaurus/babel
to encapsulate all the utils related to Babel (including code translation extraction, currently based on Babel)Note: these new packages also permit us to clean up a few hacky imports we had previously, using
import x from '@docusaurus/core/lib/...'
.Note: newly init sites will now use Babel preset
@docusaurus/babel/preset
instead ofrequire.resolve('@docusaurus/core/lib/babel/preset')
, but the later will keep working in v3 (CI E2E passed before I did the change)Test Plan
CI + preview
Test links
https://deploy-preview-10511--docusaurus-2.netlify.app/