Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facebook Like/Share Button #906

Closed
ucdstudent95618 opened this issue Aug 17, 2018 · 7 comments
Closed

Facebook Like/Share Button #906

ucdstudent95618 opened this issue Aug 17, 2018 · 7 comments
Labels
bug An error in the Docusaurus core causing instability or issues with its execution difficulty: starter Issues that are starter difficulty level, e.g. minimal tweaking with a clear test plan. good first issue If you are just getting started with Docusaurus, this issue should be a good place to begin.

Comments

@ucdstudent95618
Copy link

ucdstudent95618 commented Aug 17, 2018

🐛 Bug Report

The Facebook button in the footer is not being displayed accurately. The "Sign up" text is being wrapped around in the div and the number of people liking the page is not visible.

css_issue 2

<div><span class="hidden_elem" id="u_0_5">You and 553 others like this.&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;</span><span id="u_0_6"><span>553 people like this.</span> <span><a href="/ad_campaign/landing.php?campaign_id=137675572948107&amp;partner_id=docusaurus.io&amp;placement=like_plugin&amp;extra_1=https%3A%2F%2Fdocusaurus.io%2F&amp;extra_2=US" target="_blank">Sign Up</a> to see what your friends like.</span></span></div>

To Reproduce

(Write your steps here:)

  1. Go to Docusaurus home page
  2. Scroll to the bottom

Expected behavior

Sign up button/Facebook div should have correct CSS.

@ucdstudent95618 ucdstudent95618 changed the title Facebook button Facebook Like/Share Button Aug 17, 2018
@JoelMarcey JoelMarcey added bug An error in the Docusaurus core causing instability or issues with its execution good first issue If you are just getting started with Docusaurus, this issue should be a good place to begin. mentorship difficulty: starter Issues that are starter difficulty level, e.g. minimal tweaking with a clear test plan. labels Aug 20, 2018
@JoelMarcey
Copy link
Contributor

@ucdstudent95618 Thanks for catching this. Would love a PR if you would like to fix it. I didn't see it since I was already logged into FB, I think.

@ucdstudent95618
Copy link
Author

Yea I'll fix it

@ucdstudent95618
Copy link
Author

and you're welcome! :)

@ooridoori
Copy link

ooridoori commented Aug 28, 2018

Just fixed it! PR is here

@ucdstudent95618
Copy link
Author

I haven't had the chance to fix it. So check nancy's PR @JoelMarcey :)

@saranshkataria
Copy link
Contributor

Is this up for grabs?

@endiliey
Copy link
Contributor

@saranshkataria yup. Send a PR in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An error in the Docusaurus core causing instability or issues with its execution difficulty: starter Issues that are starter difficulty level, e.g. minimal tweaking with a clear test plan. good first issue If you are just getting started with Docusaurus, this issue should be a good place to begin.
Projects
None yet
Development

No branches or pull requests

5 participants