-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Facebook Like/Share Button #906
Labels
bug
An error in the Docusaurus core causing instability or issues with its execution
difficulty: starter
Issues that are starter difficulty level, e.g. minimal tweaking with a clear test plan.
good first issue
If you are just getting started with Docusaurus, this issue should be a good place to begin.
Comments
JoelMarcey
added
bug
An error in the Docusaurus core causing instability or issues with its execution
good first issue
If you are just getting started with Docusaurus, this issue should be a good place to begin.
mentorship
difficulty: starter
Issues that are starter difficulty level, e.g. minimal tweaking with a clear test plan.
labels
Aug 20, 2018
@ucdstudent95618 Thanks for catching this. Would love a PR if you would like to fix it. I didn't see it since I was already logged into FB, I think. |
Yea I'll fix it |
and you're welcome! :) |
Just fixed it! PR is here |
I haven't had the chance to fix it. So check nancy's PR @JoelMarcey :) |
Is this up for grabs? |
@saranshkataria yup. Send a PR in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
An error in the Docusaurus core causing instability or issues with its execution
difficulty: starter
Issues that are starter difficulty level, e.g. minimal tweaking with a clear test plan.
good first issue
If you are just getting started with Docusaurus, this issue should be a good place to begin.
🐛 Bug Report
The Facebook button in the footer is not being displayed accurately. The "Sign up" text is being wrapped around in the div and the number of people liking the page is not visible.
<div><span class="hidden_elem" id="u_0_5">You and 553 others like this. </span><span id="u_0_6"><span>553 people like this.</span> <span><a href="/ad_campaign/landing.php?campaign_id=137675572948107&partner_id=docusaurus.io&placement=like_plugin&extra_1=https%3A%2F%2Fdocusaurus.io%2F&extra_2=US" target="_blank">Sign Up</a> to see what your friends like.</span></span></div>
To Reproduce
(Write your steps here:)
Expected behavior
Sign up button/Facebook div should have correct CSS.
The text was updated successfully, but these errors were encountered: