Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed css bug for Facebook sign up text in site footer #924

Closed
wants to merge 1 commit into from

Conversation

ooridoori
Copy link

@ooridoori ooridoori commented Aug 28, 2018

Motivation

Wanted to contribute to my first open-source project!

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

Before
screen shot 2018-08-27 at 7 36 37 pm

After
screen shot 2018-08-27 at 7 36 30 pm

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Aug 28, 2018
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-preview ready!

Built with commit 999229e

https://deploy-preview-924--docusaurus-preview.netlify.com

Copy link
Contributor

@endiliey endiliey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @nancyk25 😊

  1. It seems that you ran docusaurus-init inside the repo which is adding another docusaurus project inside the project (website, and docs-examples-from-docusaurus folder inside website folder)
    You don't need to do that. Please remove it :)
  2. Seems that you had an automatic css formatter on your editor. Try to avoid changing other css not related to the facebook sign up issue

Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nancyk25 Please revert the unrelated changes.

Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nancyk25 There's still some unrelated files in this PR. I'd advise you to create a fresh new PR if you're having troubles updating this PR. Let us know how else we can help. You could ping us on Discord to get live help 😄

@endiliey
Copy link
Contributor

Create new PR if needed then

@endiliey endiliey closed this Sep 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants