Improve readibility of compare_to_baseline output message #2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D51632256 |
mgrange1998
pushed a commit
to mgrange1998/Ax
that referenced
this pull request
Nov 29, 2023
) Summary: Integrating the following feedback into the construction of the compare_to_baseline output message " I'm noticing this could be a bit easier to digest. Luckily we can use markdown formatting as follows: * add an asterisk before each item in comparison_list so that the user gets a bulleted list. * put metric name + percent improvement first, followed by arm names + absolute metric values, since the former tends to be what the user most cares about. * bolding the first part of each line item can help create visual anchors for the reader. * adding backticks can help users identify variable names/values. " Differential Revision: D51632256
mgrange1998
force-pushed
the
export-D51632256
branch
from
7b23d40
to
639c487
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51632256 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2025 +/- ##
=======================================
Coverage 94.47% 94.47%
=======================================
Files 460 460
Lines 44335 44335
=======================================
Hits 41885 41885
Misses 2450 2450 ☔ View full report in Codecov by Sentry. |
mgrange1998
pushed a commit
to mgrange1998/Ax
that referenced
this pull request
Nov 29, 2023
) Summary: Integrating the following feedback into the construction of the compare_to_baseline output message " I'm noticing this could be a bit easier to digest. Luckily we can use markdown formatting as follows: * add an asterisk before each item in comparison_list so that the user gets a bulleted list. * put metric name + percent improvement first, followed by arm names + absolute metric values, since the former tends to be what the user most cares about. * bolding the first part of each line item can help create visual anchors for the reader. * adding backticks can help users identify variable names/values. " Reviewed By: bernardbeckerman, mpolson64 Differential Revision: D51632256
mgrange1998
force-pushed
the
export-D51632256
branch
from
639c487
to
de9bd5d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51632256 |
) Summary: Integrating the following feedback into the construction of the compare_to_baseline output message " I'm noticing this could be a bit easier to digest. Luckily we can use markdown formatting as follows: * add an asterisk before each item in comparison_list so that the user gets a bulleted list. * put metric name + percent improvement first, followed by arm names + absolute metric values, since the former tends to be what the user most cares about. * bolding the first part of each line item can help create visual anchors for the reader. * adding backticks can help users identify variable names/values. " Reviewed By: bernardbeckerman, mpolson64 Differential Revision: D51632256
mgrange1998
force-pushed
the
export-D51632256
branch
from
de9bd5d
to
a345835
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51632256 |
|
This pull request has been merged in ef948b3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Integrating the following feedback into the construction of the compare_to_baseline output message
" I'm noticing this could be a bit easier to digest. Luckily we can use markdown formatting as follows:
Differential Revision: D51632256