Merge a345835 into 14a5615

facebook · Nov 29, 2023 · df20c5d · df20c5d
2 parents 14a5615 + a345835
commit df20c5d
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 14 deletions.
diff --git a/ax/service/tests/test_report_utils.py b/ax/service/tests/test_report_utils.py
@@ -1013,8 +1013,8 @@ def test_compare_to_baseline_moo(self) -> None:
             comparison_arm_names = ["opt_0", "opt_1_min", "opt_3"]
 
             preamble = (
-                "Each of the following arms optimizes a different "
-                "objective metric.<br>"
+                "Below is the greatest improvement, if any,"
+                " achieved for each objective metric \n"
             )
             output_text_0 = _format_comparison_string(
                 comparison_arm_name="opt_0",
@@ -1054,10 +1054,11 @@ def test_compare_to_baseline_moo(self) -> None:
 
             expected_result = (
                 preamble
+                + " * "
                 + output_text_0
-                + "<br>"
+                + " * "
                 + output_text_1
-                + "<br>"
+                + " * "
                 + output_text_3
             )
 

diff --git a/ax/service/utils/report_utils.py b/ax/service/utils/report_utils.py
@@ -1148,12 +1148,10 @@ def _format_comparison_string(
     digits: int,
 ) -> str:
     return (
-        f"{comparison_arm_name=} "
-        + "improves your objective metric "
-        + f"{objective_name} by {percent_change:.2f}%. "
-        + f" {baseline_arm_name=} was improved "
-        + f"from {baseline_value=:.{digits}f}"
-        + f" to {comparison_value=:.{digits}f}"
+        "**Metric "
+        f"`{objective_name}` improved {percent_change:.{digits}f}%** "
+        f"from `{baseline_value:.{digits}f}` in arm `'{baseline_arm_name}'` "
+        f"to `{comparison_value:.{digits}f}` in arm `'{comparison_arm_name}'`.\n "
     )
 
 
@@ -1339,17 +1337,17 @@ def compare_to_baseline(
     result_message = ""
     if len(comparison_list) > 1:
         result_message = (
-            "Each of the following arms optimizes a different "
-            + "objective metric.<br>"
+            "Below is the greatest improvement, if any,"
+            " achieved for each objective metric \n"
         )
 
-    for idx, result_tuple in enumerate(comparison_list):
+    for _, result_tuple in enumerate(comparison_list):
         comparison_message = _construct_comparison_message(*result_tuple)
         if comparison_message:
             result_message = (
                 result_message
+                + (" * " if len(comparison_list) > 1 else "")
                 + not_none(comparison_message)
-                + ("<br>" if idx != len(comparison_list) - 1 else "")
             )
 
     return result_message if result_message else None