Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't call dataset.X in input transform constructors #1993

Closed
wants to merge 2 commits into from
Closed

Don't call dataset.X in input transform constructors #1993

wants to merge 2 commits into from

Commits on Nov 16, 2023

  1. Remove unused imports to fix CI (facebook#1996) 

    Summary:

Fixes:
https://pxl.cl/3PLWk

Differential Revision: D51404881
    @saitcakmak @facebook-github-bot
    saitcakmak authored and facebook-github-bot committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    5d6adcb View commit details
    Browse the repository at this point in the history

  2. Don't call dataset.X in input transform constructors (facebook#1993) 

    Summary:

`dataset.X` will error out if using a `MultiTaskDataset` with heterogeneous feature sets. Updated the code to extract `d` from `feature_names` instead.

For Warp input constructor, removed the `batch_shape` argument. In Ax, we don't have batched inputs for models, so this would never get used.

Differential Revision: D51362512
    @saitcakmak @facebook-github-bot
    saitcakmak authored and facebook-github-bot committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    ac71fa5 View commit details
    Browse the repository at this point in the history