Don't call dataset.X in input transform constructors #1993
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D51362512 |
saitcakmak
added a commit
to saitcakmak/Ax
that referenced
this pull request
Nov 15, 2023
Summary: `dataset.X` will error out if using a `MultiTaskDataset` with heterogeneous feature sets. Updated the code to extract `d` from `feature_names` instead. For Warp input constructor, removed the `batch_shape` argument. In Ax, we don't have batched inputs for models, so this would never get used. Differential Revision: D51362512
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1993 +/- ##
=======================================
Coverage 94.48% 94.49%
=======================================
Files 460 460
Lines 44022 44023 +1
=======================================
+ Hits 41594 41598 +4
+ Misses 2428 2425 -3 ☔ View full report in Codecov by Sentry. |
saitcakmak
added a commit
to saitcakmak/Ax
that referenced
this pull request
Nov 15, 2023
Summary: `dataset.X` will error out if using a `MultiTaskDataset` with heterogeneous feature sets. Updated the code to extract `d` from `feature_names` instead. For Warp input constructor, removed the `batch_shape` argument. In Ax, we don't have batched inputs for models, so this would never get used. Differential Revision: D51362512
saitcakmak
added a commit
to saitcakmak/Ax
that referenced
this pull request
Nov 16, 2023
Summary: `dataset.X` will error out if using a `MultiTaskDataset` with heterogeneous feature sets. Updated the code to extract `d` from `feature_names` instead. For Warp input constructor, removed the `batch_shape` argument. In Ax, we don't have batched inputs for models, so this would never get used. Differential Revision: D51362512
saitcakmak
force-pushed
the
export-D51362512
branch
from
afd6b87
to
ffcdd12
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51362512 |
saitcakmak
added a commit
to saitcakmak/Ax
that referenced
this pull request
Nov 16, 2023
Summary: `dataset.X` will error out if using a `MultiTaskDataset` with heterogeneous feature sets. Updated the code to extract `d` from `feature_names` instead. For Warp input constructor, removed the `batch_shape` argument. In Ax, we don't have batched inputs for models, so this would never get used. Differential Revision: D51362512
Summary: Fixes: https://pxl.cl/3PLWk Differential Revision: D51404881
Summary: `dataset.X` will error out if using a `MultiTaskDataset` with heterogeneous feature sets. Updated the code to extract `d` from `feature_names` instead. For Warp input constructor, removed the `batch_shape` argument. In Ax, we don't have batched inputs for models, so this would never get used. Differential Revision: D51362512
saitcakmak
force-pushed
the
export-D51362512
branch
from
ffcdd12
to
ac71fa5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51362512 |
saitcakmak
added a commit
to saitcakmak/Ax
that referenced
this pull request
Nov 16, 2023
Summary: `dataset.X` will error out if using a `MultiTaskDataset` with heterogeneous feature sets. Updated the code to extract `d` from `feature_names` instead. For Warp input constructor, removed the `batch_shape` argument. In Ax, we don't have batched inputs for models, so this would never get used. Differential Revision: D51362512
|
This pull request has been merged in 1fe5d57. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
dataset.Xwill error out if using aMultiTaskDatasetwith heterogeneous feature sets. Updated the code to extractdfromfeature_namesinstead.For Warp input constructor, removed the
batch_shapeargument. In Ax, we don't have batched inputs for models, so this would never get used.Differential Revision: D51362512