Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load Experiment without runners and metrics in the case where search space and optimization config are immutable #1656

Closed
wants to merge 2 commits into from
Closed

Load Experiment without runners and metrics in the case where search space and optimization config are immutable #1656

wants to merge 2 commits into from

Commits on Nov 27, 2023

  1. make constraints optional in get_experiment... functions (facebook#1657) 

    Summary:

For get_experiment... core stubs functions that create a trial with Sobol, constraints were resulting in the logs being flooded with "Unable to round" warnings due to rejection sampling. This diff omits these constraints in test_sqa_store tests for which they are immaterial.

Reviewed By: Balandat

Differential Revision: D46687301
    @bernardbeckerman @facebook-github-bot
    bernardbeckerman authored and facebook-github-bot committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    7d2694d View commit details
    Browse the repository at this point in the history

  2. Load Experiment without runners and metrics in the case where search … 

    …space and optimization config are immutable (facebook#1656)

Summary:

`load_experiment` was previously failing when `skip_runners_and_metrics=True` for experiments with immutable search space and optimization config. See [Lena's comment](https://www.internalfb.com/diff/D46595953?dst_version_fbid=263061986396665&transaction_fbid=639853311380999) for more detail.

Added in V4: uses the metric type corresponding to the decoder's entry for Ax base Metric, instead of 0, which is not always the correct entry.

Reviewed By: lena-kashtelyan

Differential Revision: D46595953
    @bernardbeckerman @facebook-github-bot
    bernardbeckerman authored and facebook-github-bot committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    a6d9d59 View commit details
    Browse the repository at this point in the history