Load Experiment without runners and metrics in the case where search space and optimization config are immutable #1656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D46595953 |
bernardbeckerman
force-pushed
the
export-D46595953
branch
from
a9c9b41
to
619e6d9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D46595953 |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1656 +/- ##
=======================================
Coverage 94.51% 94.52%
=======================================
Files 460 460
Lines 44258 44291 +33
=======================================
+ Hits 41832 41864 +32
- Misses 2426 2427 +1 ☔ View full report in Codecov by Sentry. |
bernardbeckerman
pushed a commit
to bernardbeckerman/Ax
that referenced
this pull request
Jun 13, 2023
…space and optimization config are immutable (facebook#1656) Summary: Pull Request resolved: facebook#1656 `load_experiment` was previously failing when `skip_runners_and_metrics=True` for experiments with immutable search space and optimization config. See [Lena's comment](https://www.internalfb.com/diff/D46595953?dst_version_fbid=263061986396665&transaction_fbid=639853311380999) for more detail. Differential Revision: D46595953 fbshipit-source-id: ac5370fa638cf6b7a52152374339132ccb6886a9
bernardbeckerman
force-pushed
the
export-D46595953
branch
from
619e6d9
to
2fb66d1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D46595953 |
bernardbeckerman
pushed a commit
to bernardbeckerman/Ax
that referenced
this pull request
Jun 13, 2023
…space and optimization config are immutable (facebook#1656) Summary: Pull Request resolved: facebook#1656 `load_experiment` was previously failing when `skip_runners_and_metrics=True` for experiments with immutable search space and optimization config. See [Lena's comment](https://www.internalfb.com/diff/D46595953?dst_version_fbid=263061986396665&transaction_fbid=639853311380999) for more detail. Differential Revision: D46595953 fbshipit-source-id: 2c330b558efcdbe5fe64c2e0f1097a2ebde76920
bernardbeckerman
force-pushed
the
export-D46595953
branch
from
2fb66d1
to
925c7f4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D46595953 |
bernardbeckerman
pushed a commit
to bernardbeckerman/Ax
that referenced
this pull request
Jun 13, 2023
…space and optimization config are immutable (facebook#1656) Summary: Pull Request resolved: facebook#1656 `load_experiment` was previously failing when `skip_runners_and_metrics=True` for experiments with immutable search space and optimization config. See [Lena's comment](https://www.internalfb.com/diff/D46595953?dst_version_fbid=263061986396665&transaction_fbid=639853311380999) for more detail. Differential Revision: D46595953 fbshipit-source-id: 89618fbeb19c47392f30709856730721d01ffbd9
bernardbeckerman
force-pushed
the
export-D46595953
branch
from
925c7f4
to
062b975
Compare
|
This pull request was exported from Phabricator. Differential Revision: D46595953 |
bernardbeckerman
pushed a commit
to bernardbeckerman/Ax
that referenced
this pull request
Jun 21, 2023
…space and optimization config are immutable (facebook#1656) Summary: Pull Request resolved: facebook#1656 `load_experiment` was previously failing when `skip_runners_and_metrics=True` for experiments with immutable search space and optimization config. See [Lena's comment](https://www.internalfb.com/diff/D46595953?dst_version_fbid=263061986396665&transaction_fbid=639853311380999) for more detail. Added in V4: uses the metric type corresponding to the decoder's entry for Ax base Metric, instead of 0, which is not always the correct entry. Differential Revision: D46595953 fbshipit-source-id: 1f9e24735c57580ff85a8d500dde027640daad65
bernardbeckerman
force-pushed
the
export-D46595953
branch
from
062b975
to
49ac816
Compare
|
This pull request was exported from Phabricator. Differential Revision: D46595953 |
bernardbeckerman
added a commit
to bernardbeckerman/Ax
that referenced
this pull request
Nov 22, 2023
…space and optimization config are immutable (facebook#1656) Summary: `load_experiment` was previously failing when `skip_runners_and_metrics=True` for experiments with immutable search space and optimization config. See [Lena's comment](https://www.internalfb.com/diff/D46595953?dst_version_fbid=263061986396665&transaction_fbid=639853311380999) for more detail. Added in V4: uses the metric type corresponding to the decoder's entry for Ax base Metric, instead of 0, which is not always the correct entry. Reviewed By: lena-kashtelyan Differential Revision: D46595953
bernardbeckerman
force-pushed
the
export-D46595953
branch
from
49ac816
to
1a9e480
Compare
|
This pull request was exported from Phabricator. Differential Revision: D46595953 |
Summary: For get_experiment... core stubs functions that create a trial with Sobol, constraints were resulting in the logs being flooded with "Unable to round" warnings due to rejection sampling. This diff omits these constraints in test_sqa_store tests for which they are immaterial. Reviewed By: Balandat Differential Revision: D46687301
…space and optimization config are immutable (facebook#1656) Summary: `load_experiment` was previously failing when `skip_runners_and_metrics=True` for experiments with immutable search space and optimization config. See [Lena's comment](https://www.internalfb.com/diff/D46595953?dst_version_fbid=263061986396665&transaction_fbid=639853311380999) for more detail. Added in V4: uses the metric type corresponding to the decoder's entry for Ax base Metric, instead of 0, which is not always the correct entry. Reviewed By: lena-kashtelyan Differential Revision: D46595953
bernardbeckerman
force-pushed
the
export-D46595953
branch
from
1a9e480
to
a6d9d59
Compare
|
This pull request was exported from Phabricator. Differential Revision: D46595953 |
|
This pull request has been merged in 5c0d64b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D46595953