Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up console.log()s in dom.js #39

Closed
rachaelcodes opened this issue Nov 3, 2017 · 1 comment
Closed

clean up console.log()s in dom.js #39

rachaelcodes opened this issue Nov 3, 2017 · 1 comment

Comments

@rachaelcodes
Copy link

It's good that you've checked your code with console.log (where it can't be tested in tape), but don't forget to remove them from your production code - your user shouldn't be reading stuff in their console.

@rachaelcodes
Copy link
Author

On a similar note, it's best practice not to have commented code in what you're sharing - your code should be readable just as it is. I realise this is a learning project though, so it might be something to work towards in future weeks (or maybe you could have a separate 'notes' branch with the comments in?).

Gbaja added a commit that referenced this issue Nov 3, 2017
relates to #33
removed console.log's
relates to #39
@Gbaja Gbaja closed this as completed Nov 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants