Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility Review #33

Open
lexadecimals opened this issue Nov 2, 2017 · 2 comments
Open

Accessibility Review #33

lexadecimals opened this issue Nov 2, 2017 · 2 comments

Comments

@lexadecimals
Copy link
Collaborator

No description provided.

@hannahcmtucker
Copy link
Member

Heya - did an accessibility review. You guys got 91%! 😇

They mentioned buttons not being named and form input needing labels. We sorted both out by adding an aria label dynamically in the dom.js:
x.setAttribute('aria-label','message here');

@hannahcmtucker
Copy link
Member

hannahcmtucker commented Nov 3, 2017 •
edited
Loading

might be worth adding tab index '0' to your <span>s as well so the To Do text is tabable (if that is a real word)

Gbaja added a commit that referenced this issue Nov 3, 2017
@Gbaja
Added features to make web app more accessible
49a4b4e 
relates to #33
removed console.log's
relates to #39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hannahcmtucker @lexadecimals