Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node-canvas): imageSmoothing setter #8032

Merged
merged 2 commits into from
Jun 30, 2022
Merged

fix(node-canvas): imageSmoothing setter #8032

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca5d8b6
fix(node-canvas): `imageSmoothingEnabled` defaults
ShaMan123 Jun 29, 2022
d139e72
Update image-rendering-attr.png
ShaMan123 Jun 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/static_canvas.class.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -755,6 +755,7 @@
this.calcViewportBoundaries();
this.clearContext(ctx);
fabric.util.setImageSmoothing(ctx, this.imageSmoothingEnabled);
ctx.patternQuality = 'best';
Copy link
Contributor Author

@ShaMan123 ShaMan123 Jun 29, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe fast as default?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fast isn't good enough
look at the diff between best and fast
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

objectsInActiveSelections

objectsInActiveSelections

this.fire('before:render', { ctx: ctx, });
this._renderBackground(ctx);

Expand Down
Binary file modified test/visual/golden/image-rendering-attr.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.