-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(node-canvas): imageSmoothing setter #8032
Conversation
fixes #8030 override default `patternQuality`
Code Coverage Summary
|
@@ -755,6 +755,7 @@ | |||
this.calcViewportBoundaries(); | |||
this.clearContext(ctx); | |||
fabric.util.setImageSmoothing(ctx, this.imageSmoothingEnabled); | |||
ctx.patternQuality = 'best'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe fast as default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is a node-canvas non standard property, that control some cairo parameters. |
fixes #8030
override default
patternQuality
fromgood
tobest
for node canvashttps://github.com/Automattic/node-canvas/blob/0bccc05b384cc1f3e969cd9ed7859a95376ec88c/src/CanvasRenderingContext2d.cc#L1479
Should we expose a way to control
patternQuality
? Should it be set on if imageSmoothing is enabled?Seems this prop doesn't exist on the browser. The only thing I found that comes near is https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D/imageSmoothingQuality