Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies to allow node 4, node 5 and 0.10, 0.11 and 0.12 #2872

Merged
merged 4 commits into from
Apr 7, 2016
Merged

Update dependencies to allow node 4, node 5 and 0.10, 0.11 and 0.12 #2872

merged 4 commits into from
Apr 7, 2016

Conversation

asturur
Copy link
Member

@asturur asturur commented Apr 7, 2016

This should allow everyone to solve npm issues.
If travis can npm fabric, everyone should be able to do it.

@asturur
Copy link
Member Author

asturur commented Apr 7, 2016

@inssein what do you think of this? you were experimenting with jsdom 6.5.0 and over, but that was killing previous nodejs version ( that i would do on a 2.0.0 release but not now ).

This was referenced Apr 7, 2016
@inssein
Copy link
Contributor

inssein commented Apr 7, 2016

@asturur I guess this works, since jsdom 3.0 doesn't seem to break our uses cases of it. That said, I would much rather try to use the latest jsdom version (its 8.3, but this PR is using 3.0).

It would be pretty simple to use the latest version of jsdom, probably need a few more lines from my previous PR and whatever has changed since.

@asturur
Copy link
Member Author

asturur commented Apr 7, 2016

Newer jsdom is faster they say, but REQUIRES node 4.
Jsdom 3 is the latest that can handle nodejs 0.12.

@inssein
Copy link
Contributor

inssein commented Apr 7, 2016

If we are going to be releasing a 2.0, I don't see why that would be a problem. Current LTS is 4.4.2, with stable at 5.10.1. Anybody who still needs node 0.12 can stay at v1.3. of fabric.

Edit: Or it's probably a better idea to merge what you started, and upgrade to new jsdom when we get a 2.0 release.

@asturur asturur merged commit 02c4892 into fabricjs:master Apr 7, 2016
@asturur asturur deleted the jsdom-node branch April 7, 2016 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants