Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node-canvas 1.2.9 producing broken jpegs #2506

Closed
inssein opened this issue Sep 28, 2015 · 6 comments
Closed

node-canvas 1.2.9 producing broken jpegs #2506

inssein opened this issue Sep 28, 2015 · 6 comments
Labels
bug

Comments

@inssein
Copy link
Contributor

inssein commented Sep 28, 2015

I was going to submit a pull request that modifies the package.json to point to node-canvas 1.2.8 (the last working version) instead of 1.2.*, but I realized than the package will no longer support node 4.0.

What is the appropriate thing to do here?
@inssein
Copy link
Contributor Author

inssein commented Sep 28, 2015

Should be fixed after Automattic/node-canvas#635 gets merged.

@kangax kangax added the bug label Sep 29, 2015
@inssein
Copy link
Contributor Author

inssein commented Oct 12, 2015

Should be fixed in 1.2.10. Will confirm tomorrow (or somebody else can confirm today).

@inssein
Copy link
Contributor Author

inssein commented Oct 13, 2015

Can't test with 4.2.0 yet.. installation is broken (same error as travis, seems to be a problem with jsdom).

@asturur
Copy link
Member

asturur commented Oct 13, 2015

jsdom or contextify and some problem with NaN also. i tried so much to fix compilation with node 4 but i was limited to try different packages versions because i m not node expert

@inssein
Copy link
Contributor Author

inssein commented Oct 13, 2015

@asturur just sent a PR (#2547).

@asturur
Copy link
Member

asturur commented Apr 7, 2016

closed with #2872 and canvas 1.3.x

@asturur asturur closed this as completed Apr 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kangax @inssein @asturur