-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release v4 tracker #6159
Comments
Has |
it was deprecated in 2.0, removed in 4.0 |
What should be used instead?
On Sat, Feb 29, 2020 at 12:49 PM Andrea Bogazzi ***@***.***> wrote:
it was deprecated in 2.0, removed in 4.0
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#6159?email_source=notifications&email_token=AAEVUSQVUIFIC5ZKWUCX4SLRFFFEHA5CNFSM4KWFSTFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENMA6SI#issuecomment-592973641>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEVUSQJBP2HW6QTPLNUAN3RFFFEHANCNFSM4KWFSTFA>
.
--
—
Oliver Nassar
|
clipPath property on the object. clipTo has been deprecated because:
clipPath on the other hand is sometimes slower and still suffer from blurry edges |
|
http://fabricjs.com/clippath-part1 Those are the tutorials we have, follow the links there are 4 pages. |
Okay thanks! |
Hi @asturur
Thanks! |
To catalogue a svg parsing bug:
Version 4 should be actively worked on, it has a bug on the textbox handlers, a bug on using offsetX on custom controls, and also is missing the scalingFlip behaviour. |
Okay. The reason I asked was because the SVG worked fine in the Kitchensink demo, but not with |
Is there any way to fix the blurriness with |
yes can be fixed of course. is a matter to let the clippath know how much the object is zoomed. ideally is simple, for some reason is harder with nested clippaths |
okay let me know when you have a fix and i'll test it. i use vectors a lot in our app, so i can test this very extensively with all sorts of vectors (sprites, colored, etc) |
Regarding #4885 -- now I think it would be great if I can publish the pressure-sensitive brush by the time v4 is released. When would you plan to release it? |
fixed the textbox control in v4. with #6219 |
Hi @asturur |
Would be good to have a breaking changes page from version 3 to version 4. There was also a recent discussion about I've created a SandBox from the original |
the breaking changes are all collected in the changelog for now, and a page could be done. |
"object:scaling" event not return target object in Version 4.0.0-beta.9 |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
i think b11 is defintely fixing the control positioning that i wasn't able to make it work in every situation with b8-9-10. |
I have still some doubt the interface chosen is the best. The problem is balancing how much code run for each control versus how useful and versatile is the information you get in the positionHanlder to write your own. One example is padding. Padding is automatically considered by internal fabric code. We are talking about very few scripting time, but still i always try to do something that is not too much blunt. |
Refixed lockScalingFlip |
Hi, first of all: It's really great to see that much development on fabric.js. I've started using fabric.js with version 1.x and now - a few years later - the major version is already at 4. Awesome work! The thing that I am most excited about, is the controls API. I've seen this example here and it really looks impressive - can't wait to give that a try. Not sure if this is the right place to ask this question, but: Is it also possible to "build up" a polygon with points? e.g something like that: I've mimicked that behavior with fabric.js v1.x about 3 years ago and while it is still working, I would like to get rid off that code when migrating to v4 as it's hard to maintain and doesn't perform that well with big polygons (I am pretty sure, that's my fault...that was one of the first things I implemented with fabric.js and I am sure i did a lot of rookie mistakes). Is that something the controls API will be capable of or is that out of scope? |
Hi @bbernhard building a polygon with points is something that can be done with a custom brush. |
Many thanks for the reply! I hope I am not spamming this thread here, but I would have one short question regarding the custom brush: Is it possible to use custom brushes without free drawing? I always assumed that those brushes can only be used in conjunction with free drawing? And I think free drawing is probably not what I want, if I want to build up a polygon point-by-point or am I missing something here? 🤔 |
So there is not a nice brush api yet. But is not even that far. Now if that would be a decision from the brush, you would have your custom code to write to react to those situations. The difference with a brush is that you do not have to add object to the canvas during the draw process, and that the main canvas does not get refreshed while you draw. |
Many thanks - that sounds really promising. Will look into that! :) |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@asturur Hi, I am about to start new project build on fabricjs, I see there is a beta of version 4.0. Should I start building app on 3.6 and migrate to v4 when stable version will be realeased or start on 4 beta immediately? Is it posible do it without v4 docs? What is you advice? Thank you for you amazing work on this library. |
I wish you would build on 4.0 beta. The code is in good shape and any 4.0 beta bug would take precedence over anything else. It also depends what is your project is about. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
I started the descriptive API, till now this is what i got. Going to improve asap and make some interactive demo of different control setup for let people better understand what they can do. Also i think i m going to change a small interface in the api, instead of declaring a control with |
looks good @asturur. Just a note though that the new doc page looks like it's missing the bootstrap.css reference :) |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
#6448 |
My custom control handles... Works (with Fabric 3.6.1): Fails (with Fabric 4.0.0-rc.1): Are changes coming to this aspect of Fabric? |
the custom control function you wrote equal to set Fabric 4 breaks any control customization that exists today and offer an API to build them with a stable interface. |
Thanks for the prompt response! |
There are properties to make the border thicker without the need of overrides, since fabric 1.6.2 |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
go away bot |
Released. |
Verify every control has the right size// this won't be done. Can be a follow upThe text was updated successfully, but these errors were encountered: