Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setControlsVisibility not working properly in 4.0.0-beta7 #6201

Closed
onassar opened this issue Mar 3, 2020 · 10 comments · Fixed by #6226
Closed

setControlsVisibility not working properly in 4.0.0-beta7 #6201

onassar opened this issue Mar 3, 2020 · 10 comments · Fixed by #6226

Comments

@onassar
Copy link

onassar commented Mar 3, 2020

Version

4.0.0-beta7

Test Case

http://jsfiddle.net/h30rmxwq/

Information about environment

Chrome browser

Steps to reproduce

Launch fiddle; specifically, set the controls visibility on two different objects.

Expected Behavior

Each object should have their respective control visibility adhere to.

Actual Behavior

The options passed to setControlsVisibility override previous objects drawn to the canvas.
This was not happening in 3.6.0

@asturur
Copy link
Member

asturur commented Mar 4, 2020

Yes defintely something to be improved.
We coud need to move back the control visibility per object to do not disrupt functionality.
Are you interested in per Class of objects or per single object?

The idea would be mantain what fabric does today and provide examples on how to do differently.

I do not remember what fabric does today.

@onassar
Copy link
Author

onassar commented Mar 4, 2020

I'm doing it on a single object.
Today, it works on an individual object. Will it work that way in 4.0.0 as well?

@asturur
Copy link
Member

asturur commented Mar 5, 2020

yes the idea is mantain current functionality and open for customization. this can be fixed restoring some stuff deleted.

@onassar
Copy link
Author

onassar commented Mar 5, 2020

Okay. Let me know when you've committed a change and I can test it.
I'm actively working on 4.0.0-beta7, and will happily test whatever changes you make. I'm here to help :-P

@stale
Copy link

stale bot commented Mar 19, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issue marked as stale by the stale bot label Mar 19, 2020
@onassar
Copy link
Author

onassar commented Mar 19, 2020

Was this fixed in a recent commit?

@stale stale bot removed the stale Issue marked as stale by the stale bot label Mar 19, 2020
@asturur
Copy link
Member

asturur commented Mar 21, 2020

i do not think so.

@onassar
Copy link
Author

onassar commented Mar 21, 2020

Okay thanks!

@onassar
Copy link
Author

onassar commented Mar 22, 2020

Awesome! I'll test this when a new beta gets pushed up!

@duriann
Copy link

duriann commented Feb 8, 2023

Haven't fixed it yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants