fix (kubernetes-client-api) : Config should use proxy-url in kubeconfig's cluster configuration
#6289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohanKanojia
force-pushed
the
pr/issue6150
branch
from
2e93b96 to
c6a16dd
Compare
rohanKanojia
force-pushed
the
pr/issue6150
branch
2 times, most recently
from
846678c to
1d50b4f
Compare
manusa
reviewed
Aug 28, 2024
README.md
Outdated
Comment on lines
121
to
122
| | `http.proxy` / `HTTP_PROXY` | URL to the [proxy](http://www.gnu.org/software/wget/manual/html_node/Proxies.html) for HTTP requests | | | ||
| | `https.proxy` / `HTTPS_PROXY` | URL to the [proxy](http://www.gnu.org/software/wget/manual/html_node/Proxies.html) for HTTPS requests | | |
There was a problem hiding this comment.
Should at least include a link to the FAQ entry.
The behavior of these ENV variables, system properties is not the same as the behavior of the rest of entries in the list. This should be highlighted maybe with a [(*special order of precedence)](#link-to-faq) or something like that.
manusa
requested changes
Aug 28, 2024
…nfig's cluster configuration Set Config's `httpProxy` / `httpsProxy` fields if current context's cluster configuration has `proxy-url` set Signed-off-by: Rohan Kumar <[email protected]>
rohanKanojia
force-pushed
the
pr/issue6150
branch
from
1d50b4f to
d3458da
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #6150
🚧 Requires #6279 to be merged firstWhile loading
.kube/configduring auto-configuration phase, set Config'shttpProxy/httpsProxyfields if current context's cluster configuration hasproxy-urlsetSigned-off-by: Rohan Kumar [email protected]
Type of change
test, version modification, documentation, etc.)
Checklist