Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test (kubernetes-client-api) : Add test for loading proxy Urls in KubernetesClient Config #6279

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

rohanKanojia
Copy link
Member

Description

Prerequisite before fixing #6150

Add tests to ensure that current precedence of loading proxy Urls from various sources is preserved:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@rohanKanojia rohanKanojia force-pushed the pr/config-proxy-source-tests branch 2 times, most recently from ee3813d to 68ccb81 Compare August 19, 2024 10:29
…ernetesClient Config

Add tests to ensure that current precedence of loading proxy Urls from
various sources is preserved:
- proxy-url in cluster of kubeconfig (not supported)
- `all.proxy` System Property
- `http.proxy` System Property
- `configBuilder.withHttpProxy()` in ConfigBuilder

Signed-off-by: Rohan Kumar <[email protected]>
Copy link

@rohanKanojia rohanKanojia marked this pull request as ready for review August 20, 2024 04:11
@rohanKanojia rohanKanojia self-assigned this Aug 26, 2024
@manusa manusa added this to the 7.0.0 milestone Aug 26, 2024 — with automated-tasks
Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@manusa manusa merged commit 14cc2b3 into fabric8io:main Aug 26, 2024
21 checks passed
@rohanKanojia rohanKanojia deleted the pr/config-proxy-source-tests branch August 26, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants