Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore (extensions/open-virtual-networking) : Move kubernetes-model-ovn to extensions/open-virtual-networking #5737

Conversation

rohanKanojia
Copy link
Member

@rohanKanojia rohanKanojia commented Feb 1, 2024

Description

Related to #5636

As discussed in #5724 (comment) it's better to have Open Virtual Networking types available as a separate extension.

Move previously added kubernetes-model-generator/kubernetes-model-ovn to extensions/open-virtual-networking/model-v1

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@rohanKanojia rohanKanojia force-pushed the pr/migrate-open-virtual-networking-extension branch from 6e04168 to 6dc3be2 Compare February 1, 2024 07:40
@rohanKanojia rohanKanojia force-pushed the pr/migrate-open-virtual-networking-extension branch from 6dc3be2 to 6a81cf2 Compare February 1, 2024 09:51
@rohanKanojia rohanKanojia marked this pull request as ready for review February 1, 2024 11:43
…vn` to `extensions/open-virtual-networking`

As discussed in
fabric8io#5724 (comment)
it's better to have Open Virtual Networking types available as a
separate extension.

Move previously added `kubernetes-model-generator/kubernetes-model-ovn`
to `extensions/open-virtual-networking/model-v1`

Signed-off-by: Rohan Kumar <[email protected]>
@rohanKanojia rohanKanojia force-pushed the pr/migrate-open-virtual-networking-extension branch from 6a81cf2 to 3b4daa6 Compare February 1, 2024 13:33
Copy link

sonarqubecloud bot commented Feb 1, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@manusa
Copy link
Member

manusa commented Feb 1, 2024

The wip label is in the PR, @rohanKanojia is this ready?

@rohanKanojia rohanKanojia removed the wip label Feb 1, 2024
@rohanKanojia
Copy link
Member Author

rohanKanojia commented Feb 1, 2024

@manusa : Sorry, I had noticed a typo in the PR and added wip label, I forgot to remove it after updating.

It should be ready now

@manusa manusa added this to the 6.11.0 milestone Feb 1, 2024
@manusa manusa merged commit 8ff2d52 into fabric8io:main Feb 1, 2024
17 of 19 checks passed
@rohanKanojia rohanKanojia deleted the pr/migrate-open-virtual-networking-extension branch February 1, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants