-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat (extensions) : Add DSL for Open Virtual Networking k8s.ovn.org
API group resources
#5724
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good.
However, I don't understand why the model is in kubernetes-model-ovn
while the DSL is declared in the OpenShiftClient
I named the module User requested to add DSL in openshift client in #5636 (comment). We can also have it as an extension. |
I understand the user requested it in the scope of the OpenShift recommendation. However, these resources aren't exclusive to OpenShift, it would be weird to have a Kubernetes Cluster with OVN enabled and having to access this API through For me it's either making it accessible through the standard KubernetesClient DSL or creating an extension. |
I would prefer having it as an extension. If you agree I can create PR to migrate model to extensions/ |
…vn` to `extensions/open-virtual-networking` As discussed in fabric8io#5724 (comment) it's better to have Open Virtual Networking types available as a separate extension. Move previously added `kubernetes-model-generator/kubernetes-model-ovn` to `extensions/open-virtual-networking/model-v1` Signed-off-by: Rohan Kumar <[email protected]>
…vn` to `extensions/open-virtual-networking` As discussed in fabric8io#5724 (comment) it's better to have Open Virtual Networking types available as a separate extension. Move previously added `kubernetes-model-generator/kubernetes-model-ovn` to `extensions/open-virtual-networking/model-v1` Signed-off-by: Rohan Kumar <[email protected]>
…vn` to `extensions/open-virtual-networking` As discussed in fabric8io#5724 (comment) it's better to have Open Virtual Networking types available as a separate extension. Move previously added `kubernetes-model-generator/kubernetes-model-ovn` to `extensions/open-virtual-networking/model-v1` Signed-off-by: Rohan Kumar <[email protected]>
…vn` to `extensions/open-virtual-networking` As discussed in fabric8io#5724 (comment) it's better to have Open Virtual Networking types available as a separate extension. Move previously added `kubernetes-model-generator/kubernetes-model-ovn` to `extensions/open-virtual-networking/model-v1` Signed-off-by: Rohan Kumar <[email protected]>
…vn` to `extensions/open-virtual-networking` As discussed in fabric8io#5724 (comment) it's better to have Open Virtual Networking types available as a separate extension. Move previously added `kubernetes-model-generator/kubernetes-model-ovn` to `extensions/open-virtual-networking/model-v1` Signed-off-by: Rohan Kumar <[email protected]>
e1ef913
to
9b67391
Compare
k8s.ovn.org
API group resources
…vn` to `extensions/open-virtual-networking` As discussed in #5724 (comment) it's better to have Open Virtual Networking types available as a separate extension. Move previously added `kubernetes-model-generator/kubernetes-model-ovn` to `extensions/open-virtual-networking/model-v1` Signed-off-by: Rohan Kumar <[email protected]>
… API group resources Add client module to provide DSL for resources in `k8s.ovn.org` API group Signed-off-by: Rohan Kumar <[email protected]>
9b67391
to
bc20219
Compare
Quality Gate failedFailed conditions 52.2% Coverage on New Code (required ≥ 80%) |
Description
Fix #5636
Add OpenVirtualNetworkingClient with entrypoint
v1()
which will expose the following resources:ovnClient.v1().egressIps()
ovnClient.v1().egressQoses()
ovnClient.v1().egressFirewalls()
ovnClient.v1().egressServices()
ovnClient.v1().adminPolicyBasedExternalRoutes()
User would need to add this dependency in order to use this extension:
Here is an example of sample usage:
Type of change
test, version modification, documentation, etc.)
Checklist