Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore (kubernetes-client) : Remove networking.k8s.io/v1alpha1 ClusterCIDR from Kubernetes Client DSL #5687

Merged

Conversation

rohanKanojia
Copy link
Member

@rohanKanojia rohanKanojia commented Jan 4, 2024

Description

Required by #5686

networking.k8s.io/v1alpha1 ClusterCIDR has been removed from Kubernetes 1.29.

Remove references to io.fabric8.kubernetes.api.model.networking.v1alpha1.ClusterCIDR from KubernetesClient DSL

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

…erCIDR from Kubernetes Client DSL

`networking.k8s.io/v1alpha1` ClusterCIDR has been removed from Kubernetes 1.29.

Signed-off-by: Rohan Kumar <[email protected]>
Copy link

sonarqubecloud bot commented Jan 4, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@manusa manusa added this to the 6.10.0 milestone Jan 4, 2024
@manusa
Copy link
Member

manusa commented Jan 4, 2024

Please, provide a breaking change note in #5686 regarding this removal.

@manusa manusa merged commit 0d67392 into fabric8io:main Jan 4, 2024
17 of 19 checks passed
@rohanKanojia rohanKanojia deleted the pr/issue5643-remove-clustercidr branch January 4, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants