Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps (kubernetes-model-generator) : Upgrade Kubernetes Model to Kubernetes v1.29.0 (#5643) #5686

Merged
merged 2 commits into from
Jan 8, 2024

Conversation

rohanKanojia
Copy link
Member

@rohanKanojia rohanKanojia commented Jan 4, 2024

Description

Related to #5643

  • Bump k8s.io/ go dependencies in kubernetes-model-generator/go.mod to v0.29.0
  • Persist policy/v1beta1 PodSecurityPolicy to src/main/java from src/generated/java as it's deleted from Kubernetes source
  • Delete v1alpha1 classes that have been removed from Kubernetes 1.29.0 source
    • io.fabric8.kubernetes.api.model.flowcontrol.v1alpha1.FlowSchema
    • io.fabric8.kubernetes.api.model.flowcontrol.v1alpha1.PriorityLevelConfiguration
    • io.fabric8.kubernetes.api.model.networking.v1alpha1.ClusterCIDR

Newly Added Resources to Kubernetes 1.29.0 Source

Kind ApiVersion Scope
ServiceCIDR networking.k8s.io/v1alpha1 Cluster
VolumeAttributesClass storage.k8s.io/v1alpha1 Cluster
FlowSchema flowcontrol.apiserver.k8s.io/v1 Cluster
PriorityLevelConfiguration flowcontrol.apiserver.k8s.io/v1 Cluster

Resources Removed From Kubernetes 1.29.0 Source

Kind ApiVersion
FlowSchema flowcontrol.apiserver.k8s.io/v1alpha1
PriorityLevelConfiguration flowcontrol.apiserver.k8s.io/v1alpha1
ClusterCIDR networking.k8s.io/v1alpha1
PodSecurityPolicy policy/v1beta1

Other Changes:

  • Field UID removed from Kubernetes Model Networking’s ParentReference
  • PodSecurityPolicy deleted from Kubernetes sources (Its controller was deprecated in Kubernetes v1.21, see this blogpost)
  • New boolean field optionalOldSelf added to Kubernetes Model ApiExtensions’s ValidationRule
  • New field SleepAction sleep added to Kubernetes Model Core’s LifecycleHandler
  • New field String ipMode added to Kubernetes Model Core’s LoadBalancerIngress
  • New field String volumeAttributesClassName added to Kubernetes Model Core’s PersistentVolumeClaimSpec
  • PersistentVolumeClaimSpec .resources type changes to VolumeResourceRequirements from ResourceRequirements
  • New field String currentVolumeAttributesClassName added to PersistentVolumeClaimStatus
  • New field ModifyVolumeStatus modifyVolumeStatus added to PersistentVolumeClaimStatus
  • New field String volumeAttributesClassName added to PersistentVolumeSpec
  • New fields List<String> matchLabelKeys, mismatchLabelKeys added to PodAffinityTerm
  • New field ClusterTrustBundleProjection clusterTrustBundle added to VolumeProjection

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@@ -101,7 +101,7 @@ jobs:
strategy:
fail-fast: false
matrix:
kubernetes: [v1.28.1]
kubernetes: [v1.29.0, v1.28.1]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be enough to run a single version here, the other jobs have the complete matrix.
Also, I think we added this when we couldn't deploy ~1.28 on bare metal and this was introduced as a workaround. If this is the case, maybe we should just remove this job altogether.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I can see v1.28.1 in baremetal workflow too. It should be okay to delete this.

Copy link

sonarqubecloud bot commented Jan 4, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

16.6% Coverage on New Code (required ≥ 80%)
3.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@manusa manusa added this to the 6.10.0 milestone Jan 8, 2024
@manusa manusa merged commit 1a1a9f5 into fabric8io:main Jan 8, 2024
16 of 19 checks passed
@rohanKanojia rohanKanojia deleted the pr/issue5643 branch January 8, 2024 15:00
dongjoon-hyun pushed a commit to apache/spark that referenced this pull request Jan 11, 2024
### What changes were proposed in this pull request?
Upgrade `kubernetes-client` from 6.9.1 to 6.10.0
[Release notes 6.10.0](https://github.com/fabric8io/kubernetes-client/releases/tag/v6.10.0)
[Release notes 6.9.2](https://github.com/fabric8io/kubernetes-client/releases/tag/v6.9.2)

### Why are the changes needed?

[Updated okio to version 1.17.6 to avoid CVE-2023-3635](fabric8io/kubernetes-client#5587)
[Upgrade Kubernetes Model to Kubernetes v1.29.0](fabric8io/kubernetes-client#5686)

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
Pass GA

### Was this patch authored or co-authored using generative AI tooling?
No.

Closes #44672 from bjornjorgensen/kubclient6.10.

Authored-by: Bjørn Jørgensen <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
szehon-ho pushed a commit to szehon-ho/spark that referenced this pull request Aug 7, 2024
Upgrade `kubernetes-client` from 6.9.1 to 6.10.0
[Release notes 6.10.0](https://github.com/fabric8io/kubernetes-client/releases/tag/v6.10.0)
[Release notes 6.9.2](https://github.com/fabric8io/kubernetes-client/releases/tag/v6.9.2)

[Updated okio to version 1.17.6 to avoid CVE-2023-3635](fabric8io/kubernetes-client#5587)
[Upgrade Kubernetes Model to Kubernetes v1.29.0](fabric8io/kubernetes-client#5686)

No.

Pass GA

No.

Closes apache#44672 from bjornjorgensen/kubclient6.10.

Authored-by: Bjørn Jørgensen <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants