support EC private key only for mTLS auth #5657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pktxu : Is this ready for review? |
pktxu
requested review from
manusa,
oscerd,
rohanKanojia,
shawkins and
sunix
as code owners
note that I don't have access to an openshift environment, not sure what the failing checks mean |
I see thanks. The Windows / Java 11 build worked https://github.com/fabric8io/kubernetes-client/actions/runs/7264744508/job/19798701469 and the only change has been merging master in... |
shawkins
reviewed
Dec 28, 2023
kubernetes-client-api/src/main/java/io/fabric8/kubernetes/client/internal/CertUtils.java
Outdated
Show resolved
Hide resolved
kubernetes-client-api/src/main/java/io/fabric8/kubernetes/client/internal/CertUtils.java
Outdated
Show resolved
Hide resolved
kubernetes-client-api/src/test/java/io/fabric8/kubernetes/client/internal/CertUtilsTest.java
Outdated
Show resolved
Hide resolved
kubernetes-client-api/src/test/java/io/fabric8/kubernetes/client/internal/CertUtilsTest.java
Outdated
Show resolved
Hide resolved
rohanKanojia
approved these changes
Dec 29, 2023
originally introduced in fabric8io#1314 later removed in aetion@9e1d434
Signed-off-by: Marc Nuri <[email protected]>
oscerd
approved these changes
Jan 3, 2024
manusa
approved these changes
Jan 3, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable using pinniped provided EC private keys (without corresponding public key bits) to auth into a cluster.
Closes #5656
Type of change
test, version modification, documentation, etc.)
Checklist