Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for EC Private Keys #1314

Closed
trevorndodds opened this issue Jan 8, 2019 · 1 comment
Closed

Support for EC Private Keys #1314

trevorndodds opened this issue Jan 8, 2019 · 1 comment
Assignees
@rohanKanojia
Labels
feature

Comments

@trevorndodds
Copy link

Hi,

The keys I have are EC Private Keys.
-----BEGIN EC PRIVATE KEY-----

I noticed the official java kubernetes-client added support for EC Private keys in Feb 2018.
Any plans to add support?

Caused by: java.io.IOException: Invalid DER: object is not integer
        at io.fabric8.kubernetes.client.internal.PKCS1Util$Asn1Object.getInteger(PKCS1Util.java:125)
        at io.fabric8.kubernetes.client.internal.PKCS1Util.next(PKCS1Util.java:55)
        at io.fabric8.kubernetes.client.internal.PKCS1Util.decodePKCS1(PKCS1Util.java:46)
        at io.fabric8.kubernetes.client.internal.CertUtils.createKeyStore(CertUtils.java:116)
        at io.fabric8.kubernetes.client.internal.CertUtils.createKeyStore(CertUtils.java:197)
        at io.fabric8.kubernetes.client.internal.SSLUtils.keyManagers(SSLUtils.java:128)
        at io.fabric8.kubernetes.client.internal.SSLUtils.keyManagers(SSLUtils.java:122)
        at io.fabric8.kubernetes.client.utils.HttpClientUtils.createHttpClient(HttpClientUtils.java:78)
@rohanKanojia
Copy link
Member

I think it's a nice feature. We should add this to our client also

@rohanKanojia rohanKanojia self-assigned this Feb 4, 2019
rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this issue Feb 4, 2019
@rohanKanojia
Fix fabric8io#1314: Support for EC Private Keys
1666183
rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this issue Feb 6, 2019
@rohanKanojia
Fix fabric8io#1314: Support for EC Private Keys
84c39e1
rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this issue Feb 6, 2019
@rohanKanojia
Fix fabric8io#1314: Support for EC Private Keys
de54199
@rohanKanojia rohanKanojia mentioned this issue Feb 6, 2019
Merged
rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this issue Feb 6, 2019
@rohanKanojia
Fix fabric8io#1314: Support for EC Private Keys
75cefc5
rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this issue Feb 6, 2019
@rohanKanojia
Fix fabric8io#1314: Support for EC Private Keys
6cca33f
@rohanKanojia rohanKanojia mentioned this issue Mar 7, 2019
Closed
rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this issue Mar 14, 2019
@rohanKanojia
Fix fabric8io#1314: Support for EC Private Keys
3c6b331
iocanel added a commit that referenced this issue Mar 15, 2019
@iocanel
Merge pull request #1349 from rohanKanojia/pr/issue1314
f3252c4 
Fix #1314: Support for EC Private Keys
iocanel pushed a commit to iocanel/kubernetes-client that referenced this issue Mar 26, 2019
@rohanKanojia @iocanel
Fix fabric8io#1314: Support for EC Private Keys
d4fb602
pk-aetion added a commit to aetion/kubernetes-client that referenced this issue Dec 14, 2023
@pk-aetion
reintroduce tests
3d6c596 
originally introduced in fabric8io#1314 later removed in 9e1d434
pktxu added a commit to pktxu/kubernetes-client that referenced this issue Dec 19, 2023
@pktxu @pk-aetion
reintroduce tests
d46a0d1 
originally introduced in fabric8io#1314 later removed in aetion@9e1d434
manusa pushed a commit to pktxu/kubernetes-client that referenced this issue Jan 3, 2024
@pktxu @manusa
reintroduce tests
a3d954d 
originally introduced in fabric8io#1314 later removed in aetion@9e1d434
manusa added a commit that referenced this issue Jan 3, 2024
@pktxu @pk-aetion @manusa
support EC private key only for mTLS auth (#5657)
5c1dfae 
* reintroduce tests

originally introduced in #1314 later removed in aetion@9e1d434

* add failing test

* fix

* update CHANGELOG.md

* spotless formatting

* test error paths

* address PR feedback

* spotless whitespace

* address PR feedback

* review: EC private key support

Signed-off-by: Marc Nuri <[email protected]>

---------

Signed-off-by: Marc Nuri <[email protected]>
Co-authored-by: pktxu <[email protected]>
Co-authored-by: pk-aetion <[email protected]>
Co-authored-by: Marc Nuri <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rohanKanojia rohanKanojia

Labels
feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@trevorndodds @rohanKanojia