Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: release complete BOM #5190

Merged
merged 1 commit into from
May 31, 2023
Merged

ci: release complete BOM #5190

merged 1 commit into from
May 31, 2023

Conversation

manusa
Copy link
Member

@manusa manusa commented May 31, 2023

Description

Fixes #5168

Dirty workaround that allows the complete BOM (including Java11 modules) to be released.

CI workflows have been modified to manually deploy the generated BOMs. Note that since these project poms have no parent, the distribution management options must be provided as CLI arguments.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@manusa
ci: release complete BOM
65b675c 
Signed-off-by: Marc Nuri <[email protected]>
@manusa manusa added this to the 6.7.0 milestone May 31, 2023
@sonarcloud
Copy link

sonarcloud bot commented May 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

shawkins
shawkins approved these changes May 31, 2023
View reviewed changes
Copy link
Contributor

@shawkins shawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manusa manusa merged commit e76b7c0 into fabric8io:master May 31, 2023
@manusa manusa deleted the ci/release-bom branch May 31, 2023 11:58
@manusa manusa mentioned this pull request Jun 26, 2024
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscerd oscerd oscerd approved these changes

@shawkins shawkins shawkins approved these changes

@rohanKanojia rohanKanojia Awaiting requested review from rohanKanojia

@sunix sunix Awaiting requested review from sunix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.7.0
Development

Successfully merging this pull request may close these issues.

Include all httpclient artifacts in the BOM
3 participants
@manusa @shawkins @oscerd