Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include all httpclient artifacts in the BOM #5168

Closed
mattnelson opened this issue May 23, 2023 · 1 comment · Fixed by #5190
Closed

Include all httpclient artifacts in the BOM #5168

mattnelson opened this issue May 23, 2023 · 1 comment · Fixed by #5190
Assignees
Labels
Milestone

Comments

@mattnelson
Copy link

Is your enhancement related to a problem? Please describe

The kubernetes-client-bom does not include entries for the jdk/jetty http client implementations. When using either of them additional dependency management is needed.

dependency management

<properties>
  <k8s.client.version>6.6.2</k8s.client.version>
</properties>
<dependencyManagement>
  <dependencies>
    <dependency>
      <groupId>io.fabric8</groupId>
      <artifactId>kubernetes-client-bom</artifactId>
      <version>${k8s.client.version}</version>
      <type>pom</type>
      <scope>import</scope>
    </dependency>
+  <dependency> <!-- this GAV should be managed in the BOM -->
+    <groupId>io.fabric8</groupId>
+    <artifactId>kubernetes-httpclient-jdk</artifactId>
+    <version>${k8s.client.version}</version>
+  </dependency>
  </dependencies>
</dependencyManagement>

Describe the solution you'd like

Add kubernetes-httpclient-jdk and kubernetes-httpclient-jetty to kubernetes-client-bom

Describe alternatives you've considered

Continue managing explicitly.

Additional context

The vertx client is managed in the bom

@manusa manusa added the bug label May 24, 2023
@manusa manusa added this to the 6.7.0 milestone May 24, 2023
@rohanKanojia rohanKanojia moved this to Planned in Eclipse JKube May 31, 2023
@manusa manusa self-assigned this May 31, 2023
@manusa manusa moved this from Planned to In Progress in Eclipse JKube May 31, 2023
@manusa
Copy link
Member

manusa commented May 31, 2023

Indeed, the 2 mentioned HttpClient modules are missing from https://repo1.maven.org/maven2/io/fabric8/kubernetes-client-bom/6.6.2/kubernetes-client-bom-6.6.2.pom

These modules require Java11+, so that's why they're excluded from the Java8 bundles.

I'll try to find a workaround to include these modules only for the BOM packaging.

@manusa manusa mentioned this issue May 31, 2023
11 tasks
@manusa manusa moved this from In Progress to Review in Eclipse JKube May 31, 2023
@github-project-automation github-project-automation bot moved this from Review to Done in Eclipse JKube May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants