Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #5033: allow port-forward to work with other clients #5039

Merged
merged 1 commit into from
Apr 19, 2023
Merged

fix #5033: allow port-forward to work with other clients #5039

merged 1 commit into from
Apr 19, 2023

Conversation

shawkins
Copy link
Contributor

@shawkins shawkins commented Apr 6, 2023 •
edited by manusa
Loading

Description

Fix #5033 - other clients need an explicit subprotocol. Added an integration test as well.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@shawkins shawkins force-pushed the iss5033 branch 4 times, most recently from c59cfb9 to 527dc34 Compare April 6, 2023 19:12
@shawkins shawkins mentioned this pull request Apr 7, 2023
Closed
@manusa manusa added this to the 6.6.0 milestone Apr 11, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@manusa manusa merged commit 0a72414 into fabric8io:master Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohanKanojia rohanKanojia rohanKanojia approved these changes

@manusa manusa manusa approved these changes

@oscerd oscerd Awaiting requested review from oscerd

@sunix sunix Awaiting requested review from sunix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.6.0
Development

Successfully merging this pull request may close these issues.

Port-forward does not work with Vert.x HTTP Client
3 participants
@shawkins @manusa @rohanKanojia