Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #4530: allowing serialization to better handle primitive values #4533

Merged
merged 3 commits into from
Nov 11, 2022
Merged

fix #4530: allowing serialization to better handle primitive values #4533

merged 3 commits into from
Nov 11, 2022

Conversation

shawkins
Copy link
Contributor

@shawkins shawkins commented Oct 26, 2022 •
edited by manusa
Loading

Description

Fixes #4530 - this removes some of the remaining cases where the KubernetesDeserializer was returning null and generalizes support for primitive values.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@shawkins shawkins requested review from manusa and andreaTP October 26, 2022 12:37
@shawkins shawkins mentioned this pull request Oct 26, 2022
Closed
andreaTP
andreaTP approved these changes Oct 26, 2022
View reviewed changes
Copy link
Member

@andreaTP andreaTP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM having this one in I would be able to use the integration test included in #4536.
Thanks!

@shawkins shawkins marked this pull request as ready for review October 26, 2022 17:27
@manusa manusa self-assigned this Nov 8, 2022
@manusa manusa force-pushed the serialization_4530 branch from 55787d3 to 48ff68a Compare November 11, 2022 09:52
@manusa manusa force-pushed the serialization_4530 branch from 48ff68a to 6d37cba Compare November 11, 2022 09:57
@manusa manusa added this to the 6.3.0 milestone Nov 11, 2022
@manusa manusa mentioned this pull request Nov 11, 2022
Closed
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

67.9% 67.9% Coverage
0.0% 0.0% Duplication

@manusa manusa merged commit 9d4d124 into fabric8io:master Nov 11, 2022
@shawkins shawkins mentioned this pull request Nov 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreaTP andreaTP andreaTP approved these changes

@manusa manusa manusa approved these changes

Assignees

@manusa manusa

Labels
None yet
Projects
None yet
Milestone
6.3.0
Development

Successfully merging this pull request may close these issues.

Primitive default values in specifications break the object instantiation
3 participants
@shawkins @manusa @andreaTP