Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix primitive types encoding of default values #4536

Merged
merged 1 commit into from
Nov 16, 2022
Merged

Fix primitive types encoding of default values #4536

merged 1 commit into from
Nov 16, 2022

Conversation

andreaTP
Copy link
Member

Description

Fix #4530

Here I'm proposing to specialize the encoding of default values skipping the Jackson deserialization completely.

This is not complete yet as the handling of primitive arrays is still broken. cc. @shawkins

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@andreaTP
Copy link
Member Author

cc. @fabiobrz as he was the original contributor of this feature.

@andreaTP andreaTP marked this pull request as ready for review November 11, 2022 14:46
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

81.2% 81.2% Coverage
0.0% 0.0% Duplication

@manusa manusa added this to the 6.3.0 milestone Nov 16, 2022
@manusa manusa merged commit 3edb1b2 into fabric8io:master Nov 16, 2022
@mteubner mteubner mentioned this pull request Dec 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriansuarez adriansuarez adriansuarez approved these changes

@manusa manusa manusa approved these changes

@rohanKanojia rohanKanojia Awaiting requested review from rohanKanojia

@shawkins shawkins Awaiting requested review from shawkins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.3.0
Development

Successfully merging this pull request may close these issues.

Primitive default values in specifications break the object instantiation
3 participants
@andreaTP @manusa @adriansuarez