Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: tests in appropriate packages after split #3886

Merged
merged 1 commit into from
Feb 22, 2022

Conversation

manusa
Copy link
Member

@manusa manusa commented Feb 22, 2022

Description

Follow up on #3844 / #3835.
Moved tests to the right modules and packages.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@manusa manusa force-pushed the chore/split-packages branch from f448d51 to 8f4fbe1 Compare February 22, 2022 11:41
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 10 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@shawkins
Copy link
Contributor

Let's merge this one then I'll rebase #3858

@manusa manusa added this to the 6.0.0 milestone Feb 22, 2022
@manusa manusa merged commit c3ec8cf into fabric8io:master Feb 22, 2022
@manusa manusa deleted the chore/split-packages branch February 22, 2022 15:00
Copy link
Contributor

@shawkins shawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - the only thing that looks a little odd is the MapIndexer. Did it seem about the same amount of work to create that vs. targeted mocking?

@manusa
Copy link
Member Author

manusa commented Feb 22, 2022

the only thing that looks a little odd is the MapIndexer. Did it seem about the same amount of work to create that vs. targeted mocking?

It seemed like a more realistic and maintainable scenario, plus helped me understand a few things. I considered mocking, but it was turning out to be an extremely white-boxed test which didn't add much value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants