Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #3853 addressing split packages as much as possible #3844

Merged
merged 2 commits into from
Feb 22, 2022

Conversation

shawkins
Copy link
Contributor

@shawkins shawkins commented Feb 11, 2022

Description

first commit:
dsl.base -> dsl.internal
extended.run -> moves to client api as something that just leverages a KubernetesClient

second commit:
informers -> informers.impl (an odd man out in terms of naming convention)
utils -> utils.internal (and a couple more util classes were moved out of api)

I don't think I'll do anything with the classes in the client packages as this time as the split there is unavoidable to keep the Default clients in their original package.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants