Moving readiness and adding changelog for initial api changes #3833
Conversation
|
I think we should move KubernetesDeserializer out of internal package. I would leave rest of the classes there as it is since no one really requested exposing them. |
separate documentation will be needed over the usage of the api modules, but that can be done once we've finalized how the user is creating the client instances
… split/repackaging
|
SonarCloud Quality Gate failed. |
I wouldn't expose any of those classes. They are used internally (, and IMHO need some refactoring)
I think it might be better to expose a KubernetesClient#registerCustomKind, if this is something that we want. |
| * Refactoring #3654: | ||
| * Removed deprecated KubernetesClient.customResource / RawCustomResourceOperationsImpl, please use the generic resource api instead | ||
| * Removed deprecatedHttpClientUtils.createHttpClient(final Config config, final Consumer<OkHttpClient.Builder> additionalConfig), please use the OkHttpClientFactory instead | ||
| * Removed deprecated methods on SharedInformerFactory dealing with the OperationContext | ||
| * Refactoring #2838: Readiness/OpenShiftReadiness moved from client.internal.readiness to client.readiness |
There was a problem hiding this comment.
Some of these should definitely go into the https://github.com/fabric8io/kubernetes-client/blob/master/doc/MIGRATION-v6.md
There was a problem hiding this comment.
Since this list is bound to grow off limits, maybe it's better to just link to the migration guide WDYT?
Description
Followup to the api split #3654 to move readiness to resolve #2838
The proposal here is for a breaking change, users would need to update the packages.
That will leave just client.internal as an internal package in the api module. It has several utility classes: https://github.com/fabric8io/kubernetes-client/tree/master/kubernetes-client-api/src/main/java/io/fabric8/kubernetes/client/internal
@manusa @rohanKanojia do you want move those as well, or leave them internal? And what about #1285
Type of change
test, version modification, documentation, etc.)
Checklist