Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readiness utility should not be flagged as internal #2838

Closed
iocanel opened this issue Feb 25, 2021 · 1 comment · Fixed by #3833
Closed

Readiness utility should not be flagged as internal #2838

iocanel opened this issue Feb 25, 2021 · 1 comment · Fixed by #3833
Labels
status/never-stale
Milestone
6.0.0

Comments

@iocanel
Copy link
Member

iocanel commented Feb 25, 2021

Currently Readiness singleton / utility is under internal package and as such is treated as internal.
However, its not internal in practice as there are already downstream projects using it.

So, it would make sense for the next major release to move it somewhere else and consider it public.
@manusa manusa added this to the 6.0.0 milestone Mar 2, 2021
@rohanKanojia rohanKanojia mentioned this issue Mar 4, 2021
Merged
11 tasks
@stale
Copy link

stale bot commented May 31, 2021

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

@stale stale bot added the status/stale label May 31, 2021
@stale stale bot removed the status/stale label Jun 4, 2021
@manusa manusa mentioned this issue Jul 12, 2021
Closed
@shawkins shawkins mentioned this issue Feb 9, 2022
Merged
11 tasks
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Feb 10, 2022
@shawkins
fix fabric8io#2838: moving Readiness out of an internal package
aba8f9c
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Feb 10, 2022
@shawkins
fix fabric8io#2838: moving Readiness out of an internal package
5d2b283
@shawkins shawkins mentioned this issue Feb 10, 2022
Merged
11 tasks
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Feb 14, 2022
@shawkins
fix fabric8io#3645 fabric8io#2838 migration guide entries for the api…
493d960 
… split/repackaging
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Feb 14, 2022
@shawkins
fix fabric8io#3645 fabric8io#2838 migration guide entries for the api…
b3bca2f 
… split/repackaging
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Feb 14, 2022
@shawkins
fix fabric8io#2838: moving Readiness out of an internal package
e879dfc
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Feb 14, 2022
@shawkins
fix fabric8io#3645 fabric8io#2838 migration guide entries for the api…
0640a35 
… split/repackaging
manusa pushed a commit that referenced this issue Feb 15, 2022
@shawkins @manusa
fix #2838: moving Readiness out of an internal package
a6e0078
manusa pushed a commit that referenced this issue Feb 15, 2022
@shawkins @manusa
fix #3645 #2838 migration guide entries for the api split/repackaging
71153e0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status/never-stale
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Moving readiness and adding changelog for initial api changes shawkins/kubernetes-client
2 participants
@iocanel @manusa