Limit usage of YAML Serializer #3796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
rohanKanojia
requested review from
oscerd,
metacosm,
manusa,
shawkins and
sunix
|
One usage of the YAML parser that needs to be taken into account is that people very often load an initial/skeleton resource from YAML and then populate it with values at runtime, so this use case needs to be taken into account as well. |
oscerd
approved these changes
Feb 2, 2022
manusa
approved these changes
Feb 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The YAML serializer is mainly used in order to parse the kubernetes config.
This change should not have any functional effect whatsoever, but it paves the way for what I have in mind as a follow-up, which is to provide a public method that allows for clearing out the YAMLMapper (the reasoning being that this is a very heavy object that most likely is only used when the client is first booted).