Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

examples still use -client internal SerializationUtils #3866

Closed
shawkins opened this issue Feb 15, 2022 · 2 comments · Fixed by #3915
Closed

examples still use -client internal SerializationUtils #3866

shawkins opened this issue Feb 15, 2022 · 2 comments · Fixed by #3915
Assignees
@manusa
Milestone
6.0.0

Comments

@shawkins
Copy link
Contributor

Is your task related to a problem? Please describe

Examples should ideally not use -client internal classes.

Describe the solution you'd like

Rewrite the example or move SerializationUtils to the api.

Describe alternatives you've considered

No response

Additional context

No response
@shawkins shawkins added this to the 6.0.0 milestone Feb 15, 2022
@shawkins shawkins mentioned this issue Feb 15, 2022
Closed
@shawkins
Copy link
Contributor Author

Possibly related to #3796

Also this yaml mapper differs from the one in Serialization - dumpAsYaml, should just be Serialization.asYaml.

dumpWithoutRuntimeStateAsYaml is really specific to ReplicationControllers - seems like it should be moved / renamed - maybe introduce ReplicationContollerResource.getYaml()

@manusa manusa self-assigned this Mar 2, 2022
This was referenced Mar 2, 2022
Merged
Closed
@manusa
Copy link
Member

manusa commented Mar 2, 2022

Removed usage in Examples (#3915) and opened a new issue to discuss the future of SerializationUtils.

@manusa manusa moved this to Review in Eclipse JKube Mar 2, 2022
@manusa manusa moved this from Review to In Progress in Eclipse JKube Mar 3, 2022
@manusa manusa moved this from In Progress to Review in Eclipse JKube Mar 3, 2022
Repository owner moved this from Review to Done in Eclipse JKube Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manusa manusa

Labels
None yet
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

doc: Examples usage of internal class SerializationUtils manusa/kubernetes-client
2 participants
@manusa @shawkins