fix: Cannot change the type of the Service from ClusterIP to External… #2855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
oscerd
approved these changes
Mar 2, 2021
manusa
approved these changes
Mar 3, 2021
…Name with PATCH Signed-off-by: Jorge Solórzano <[email protected]>
|
Off-topic... not sure if this works, but to avoid conflicts on CHANGELOG.md probably adding a should do the trick. |
rohanKanojia
approved these changes
Mar 3, 2021
Not sure if GitHub will automatically resolve merge conflicts using the |
|
SonarCloud Quality Gate failed. |
rohanKanojia
added a commit
to rohanKanojia/kubernetes-client
that referenced
this pull request
Mar 12, 2021
…ethods can't be combined resource() deletion + Add gracePeriodSeconds parameter in ResourceHandler#delete + Modified CascadingDeletable interface so that it includes GracePeriodConfigurable and PropagationPolicyConfiguratble
rohanKanojia
added a commit
to rohanKanojia/kubernetes-client
that referenced
this pull request
Mar 12, 2021
…ethods can't be combined resource() deletion + Add gracePeriodSeconds parameter in ResourceHandler#delete + Modified CascadingDeletable interface so that it includes GracePeriodConfigurable and PropagationPolicyConfiguratble
manusa
pushed a commit
that referenced
this pull request
Mar 12, 2021
…n't be combined resource() deletion + Add gracePeriodSeconds parameter in ResourceHandler#delete + Modified CascadingDeletable interface so that it includes GracePeriodConfigurable and PropagationPolicyConfiguratble
This was referenced Mar 12, 2021
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2853
Description
Type of change
test, version modification, documentation, etc.)
Checklist
(There are some style changes, sorry for that)