-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot change the type of the Service from ClusterIP to ExternalName with PATCH #2853
Closed
jorsol opened this issue
Mar 2, 2021
· 4 comments
· Fixed by #2855 or jenkinsci/kubernetes-client-api-plugin#83
Closed
Cannot change the type of the Service from ClusterIP to ExternalName with PATCH #2853
jorsol opened this issue
Mar 2, 2021
· 4 comments
· Fixed by #2855 or jenkinsci/kubernetes-client-api-plugin#83
Comments
@jorsol : Thanks a lot for reporting this, Would it be possible for you to submit a fix for this issue? |
Yes, I could submit a fix for this issue. |
11 tasks
Is there an ETA for 5.2.0? |
We're planning on releasing by the end of next week or beginning of the other. |
11 tasks
This was referenced Mar 12, 2021
This was referenced Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The PR #2472 fixed the replace method, but the patch method should also handle the update of the service to ExternalName.
It assumes a patch with ClusterIP:
kubernetes-client/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/internal/core/v1/ServiceOperationsImpl.java
Lines 66 to 77 in 33a735a
The text was updated successfully, but these errors were encountered: