Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2218: Uberjar: Package rewrite issues in META-INF/services #2234

Merged
merged 1 commit into from
May 21, 2020
Merged

Fix #2218: Uberjar: Package rewrite issues in META-INF/services #2234

merged 1 commit into from
May 21, 2020

Conversation

rohanKanojia
Copy link
Member

Fix #2218

@manusa manusa self-requested a review May 18, 2020 08:15
@rohanKanojia
Copy link
Member Author

retest this please

manusa
manusa approved these changes May 18, 2020
View reviewed changes
Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the version calculation method, LGTM, thx for adding the test-case I think it will come really useful in the future.

@rohanKanojia
Fix fabric8io#2218: Uberjar: Package rewrite issues in META-INF/services
88c9a78 
Looks like space in `resource-handler-services.vm` file was the root cause of
the issue 😆
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rohanKanojia
Copy link
Member Author

[merge]

@fusesource-ci fusesource-ci merged commit 7e0ad2e into fabric8io:master May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscerd oscerd oscerd approved these changes

@manusa manusa manusa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Uberjar: Package rewrite issues in META-INF/services
4 participants
@rohanKanojia @manusa @oscerd @fusesource-ci