Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uberjar: Package rewrite issues in META-INF/services #2218

Closed
cheinema opened this issue May 12, 2020 · 2 comments · Fixed by #2234
Closed

Uberjar: Package rewrite issues in META-INF/services #2218

cheinema opened this issue May 12, 2020 · 2 comments · Fixed by #2234
Assignees
@rohanKanojia
Labels
bug

Comments

@cheinema
Copy link

Since #2137 (v1.10.0) not all references in META-INF/services/io.fabric8.kubernetes.clnt.v4_10.ResourceHandler contained in the Uberjar kubernetes-openshift-uberjar-4.10.0-versioned.jar are rewritten to the versioned package notation.
@rohanKanojia
Copy link
Member

I think #2203 should take care of this. Do you see this issue on master SNAPSHOT as well?

@rohanKanojia
Copy link
Member

Umm, yeah. The issue is still there in the master as well :-(

@manusa manusa added the bug label May 12, 2020
@rohanKanojia rohanKanojia self-assigned this May 15, 2020
rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this issue May 15, 2020
@rohanKanojia
Fix fabric8io#2218: Uberjar: Package rewrite issues in META-INF/services
9730830 
Looks like space in `resource-handler-services.vm` file was the root cause of
the issue 😆
@rohanKanojia rohanKanojia mentioned this issue May 15, 2020
Merged
rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this issue May 18, 2020
@rohanKanojia
Fix fabric8io#2218: Uberjar: Package rewrite issues in META-INF/services
80bbd0a 
Looks like space in `resource-handler-services.vm` file was the root cause of
the issue 😆
rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this issue May 19, 2020
@rohanKanojia
Fix fabric8io#2218: Uberjar: Package rewrite issues in META-INF/services
fcef2d6 
Looks like space in `resource-handler-services.vm` file was the root cause of
the issue 😆
rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this issue May 20, 2020
@rohanKanojia
Fix fabric8io#2218: Uberjar: Package rewrite issues in META-INF/services
88c9a78 
Looks like space in `resource-handler-services.vm` file was the root cause of
the issue 😆
@manusa manusa mentioned this issue Jul 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rohanKanojia rohanKanojia

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #2218: Uberjar: Package rewrite issues in META-INF/services rohanKanojia/kubernetes-client
3 participants
@cheinema @manusa @rohanKanojia