fix: Uber Jar includes merged service entry for multiple implementations of the same interface #2211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
rohanKanojia
approved these changes
May 8, 2020
rohanKanojia
reviewed
May 8, 2020
…ons of the same interface Apparently uber-jar configuration has been wrong for a while now. Service entry declarations were being lost because they collided both for openshift-client and for kubernetes-client modules. uberjar: `maven-shade-plugin:3.2.3:shade ` ``` [WARNING] kubernetes-client-4.10-SNAPSHOT.jar, kubernetes-openshift-uberjar-4.10-SNAPSHOT.jar, openshift-client-4.10-SNAPSHOT.jar define 3 overlapping resources: [WARNING] - META-INF/services/io.fabric8.kubernetes.client.ExtensionAdapter [WARNING] - META-INF/services/io.fabric8.kubernetes.client.ResourceHandler [WARNING] - META-INF/services/io.fabric8.kubernetes.client.ServiceToURLProvider ``` See: https://maven.apache.org/plugins/maven-shade-plugin/examples/resource-transformers.html#ServicesResourceTransformer
manusa
force-pushed
the
fix/#2066-missing-handlers-in-uber-jar
branch
from
16c9850 to
7bb4a9f
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
[merge] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently uber-jar configuration has been wrong for a while now.
Service entry declarations were being lost because they collided both for openshift-client and
for kubernetes-client modules.
uberjar:
maven-shade-plugin:3.2.3:shadeSee: https://maven.apache.org/plugins/maven-shade-plugin/examples/resource-transformers.html#ServicesResourceTransformer
Should fix: #2066