Skip to content

Commit

Permalink
fix: Uber Jar includes merged service entry for multiple implementati…
Browse files Browse the repository at this point in the history
…ons of the same interface

Apparently uber-jar configuration has been wrong for a while now.

Service entry declarations were being lost because they collided both for openshift-client and
for kubernetes-client modules.

uberjar: `maven-shade-plugin:3.2.3:shade `
```
[WARNING] kubernetes-client-4.10-SNAPSHOT.jar, kubernetes-openshift-uberjar-4.10-SNAPSHOT.jar, openshift-client-4.10-SNAPSHOT.jar define 3 overlapping resources:
[WARNING]   - META-INF/services/io.fabric8.kubernetes.client.ExtensionAdapter
[WARNING]   - META-INF/services/io.fabric8.kubernetes.client.ResourceHandler
[WARNING]   - META-INF/services/io.fabric8.kubernetes.client.ServiceToURLProvider
```

See: https://maven.apache.org/plugins/maven-shade-plugin/examples/resource-transformers.html#ServicesResourceTransformer
  • Loading branch information
manusa committed May 8, 2020
1 parent 49867e9 commit 16c9850
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
### 4.10.1 (2020-05-06)
#### Bugs
* Fix #2189: Change package names of Resource Operation classes in order to avoid duplicates Operation classes
* Fix #2066: Uber Jar includes merged service entry for multiple implementations of the same interface

#### Improvements

Expand Down
3 changes: 3 additions & 0 deletions uberjar/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,9 @@
<include>io.fabric8:openshift-server-mock</include>
</includes>
</artifactSet>
<transformers>
<transformer implementation="org.apache.maven.plugins.shade.resource.ServicesResourceTransformer" />
</transformers>
</configuration>
</execution>
<execution>
Expand Down

0 comments on commit 16c9850

Please sign in to comment.