URLUtils.isValidURL

[shawkins]

In this method there's a check of if the string form contains the string null, presumably to guard against null concatenation. However in general it's quite possible for the string "null" to appear in a valid URL.

kubernetes-client/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/utils/URLUtils.java

Line 151 in d1740ff

return url.contains("null") ? false : true;

[MUzairS15]

Can you help me understand better? Under what conditions, this check may fail.

[manusa]

😳 This check should probably be removed.

Added in #1139, not sure why.

[MUzairS15]

In the project,this is used only at following two locations:
https://github.com/fabric8io/kubernetes-client/blob/master/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/internal/core/v1/ServiceOperationsImpl.java

https://github.com/fabric8io/kubernetes-client/blob/master/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/utils/URLUtils.java
I removed them and project build successfully, so should I proceed ahead creating PR for the same.

[manusa]

To be clear, the only thing you should remove is the url.contains("null") check, the rest should stay.

[manusa]

@MUzairS15 are you working on this and going to provide a PR?

[rohanKanojia]

Looks like @MUzairS15 had created PR but didn't link the issue #3558

[MUzairS15]

Sorry @manusa I didn't linked the issue, thankyou @rohanKanojia for mentioning