-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it easy to get the URL of a service. #1139
Labels
Comments
rohanKanojia
added a commit
to rohanKanojia/kubernetes-client
that referenced
this issue
Jul 14, 2018
@rohanKanojia: following up your question on irc. I think that should have different implementations for each strategy.
Then the actual implementation can use the java.util.ServiceLoader to load these implementations. Each impl can also have a priority and maybe a method to return if the address is public or private. |
rohanKanojia
added a commit
to rohanKanojia/kubernetes-client
that referenced
this issue
Jul 26, 2018
rohanKanojia
added a commit
to rohanKanojia/kubernetes-client
that referenced
this issue
Jul 30, 2018
@iocanel yes there should be an |
rohanKanojia
added a commit
to rohanKanojia/kubernetes-client
that referenced
this issue
Jul 31, 2018
rohanKanojia
added a commit
to rohanKanojia/kubernetes-client
that referenced
this issue
Aug 2, 2018
+ Implemented getUrl() method for service + Fixed an arquillian dependency error that comes up while running tests in IntelliJ
rohanKanojia
added a commit
to rohanKanojia/kubernetes-client
that referenced
this issue
Aug 7, 2018
+ Implemented getUrl() method for service + Fixed an arquillian dependency error that comes up while running tests in IntelliJ
rohanKanojia
added a commit
to rohanKanojia/kubernetes-client
that referenced
this issue
Aug 20, 2018
+ Implemented getUrl() method for service + Fixed an arquillian dependency error that comes up while running tests in IntelliJ
rohanKanojia
added a commit
to rohanKanojia/kubernetes-client
that referenced
this issue
Aug 20, 2018
+ Implemented getUrl() method for service + Fixed an arquillian dependency error that comes up while running tests in IntelliJ
rohanKanojia
added a commit
to rohanKanojia/kubernetes-client
that referenced
this issue
Aug 20, 2018
+ Implemented getUrl() method for service + Fixed an arquillian dependency error that comes up while running tests in IntelliJ
rohanKanojia
added a commit
to rohanKanojia/kubernetes-client
that referenced
this issue
Aug 20, 2018
+ Implemented getUrl() method for service + Fixed an arquillian dependency error that comes up while running tests in IntelliJ
rohanKanojia
added a commit
to rohanKanojia/kubernetes-client
that referenced
this issue
Aug 20, 2018
+ Implemented getUrl() method for service + Fixed an arquillian dependency error that comes up while running tests in IntelliJ
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We need something like:
The implementation of the
getURL()
should be similar with what is provided byKubernetesHelper.getServiceURL()
, but it should be implemented cleanly.It might make sense to have different strategies for doing service -> url. For example when using openshift-client it might make sense to take Routes into consideration. So, I would use java.util.ServiceLoader to dynamically load the providers of this functionality. It also might make sense each provider to have a toggle and a priority assigned to it.
DSL wise we just need to introduce ServiceResource that will work in the same spririt as PodResource etc.
The text was updated successfully, but these errors were encountered: