fix (BuildService) : Image Build Config BuildArgs should be passed while pulling images (#1756) #1759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1759 +/- ##
============================================
- Coverage 65.76% 65.75% -0.01%
- Complexity 2294 2295 +1
============================================
Files 172 172
Lines 10184 10181 -3
Branches 1405 1405
============================================
- Hits 6697 6695 -2
Misses 2934 2934
+ Partials 553 552 -1
|
…ile pulling images (fabric8io#1756) Fixes regression introduced by fabric8io#1731 In fabric8io#1731, we added support for specifying docker build args from maven/system properties. However, I missed it in review that build args specified in plugin image build configuration are no longer passed to autoPullBaseImage. Ensure we merge image build configuration build args with args provided via maven/system properties before passing them to autoPullBaseImage Signed-off-by: Rohan Kumar <[email protected]>
rohanKanojia
force-pushed
the
pr/issue1756
branch
from
5e6b73a
to
8fa0c7b
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #1756
Fixes regression introduced by #1731
In #1731, we added support for specifying docker build args from maven/system properties. However, I missed it in review that build args specified in plugin image build configuration are no longer passed to autoPullBaseImage.
Ensure we merge image build configuration build args with args provided via maven/system properties before passing them to autoPullBaseImage