Add support for using maven/system properties for an ARG used as the FROM image in a dockerfile #1731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…FROM image in a dockerfile
|
Kudos, SonarCloud Quality Gate passed!
|
rohanKanojia
approved these changes
Dec 9, 2023
|
@sdumitriu : Thanks a lot! |
rohanKanojia
added a commit
to rohanKanojia/docker-maven-plugin
that referenced
this pull request
Feb 23, 2024
…ile pulling images (fabric8io#1756) Fixes regression introduced by fabric8io#1731 In fabric8io#1731, we added support for specifying docker build args from maven/system properties. However, I missed it in review that build args specified in plugin image build configuration are no longer passed to autoPullBaseImage. Ensure we merge image build configuration build args with args provided via maven/system properties before passing them to autoPullBaseImage Signed-off-by: Rohan Kumar <[email protected]>
rohanKanojia
added a commit
to rohanKanojia/docker-maven-plugin
that referenced
this pull request
Feb 23, 2024
…ile pulling images (fabric8io#1756) Fixes regression introduced by fabric8io#1731 In fabric8io#1731, we added support for specifying docker build args from maven/system properties. However, I missed it in review that build args specified in plugin image build configuration are no longer passed to autoPullBaseImage. Ensure we merge image build configuration build args with args provided via maven/system properties before passing them to autoPullBaseImage Signed-off-by: Rohan Kumar <[email protected]>
rohanKanojia
added a commit
to rohanKanojia/docker-maven-plugin
that referenced
this pull request
Feb 24, 2024
…ile pulling images (fabric8io#1756) Fixes regression introduced by fabric8io#1731 In fabric8io#1731, we added support for specifying docker build args from maven/system properties. However, I missed it in review that build args specified in plugin image build configuration are no longer passed to autoPullBaseImage. Ensure we merge image build configuration build args with args provided via maven/system properties before passing them to autoPullBaseImage Signed-off-by: Rohan Kumar <[email protected]>
rohanKanojia
added a commit
that referenced
this pull request
Feb 24, 2024
…ile pulling images (#1756) Fixes regression introduced by #1731 In #1731, we added support for specifying docker build args from maven/system properties. However, I missed it in review that build args specified in plugin image build configuration are no longer passed to autoPullBaseImage. Ensure we merge image build configuration build args with args provided via maven/system properties before passing them to autoPullBaseImage Signed-off-by: Rohan Kumar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scenario: build using a Dockerfile, I'm trying to configure the base image using an ARG, as in:
This works as long as I don't want a different base image, or if I configure it in the image settings. In theory
docker.buildArg.baseImage=ghcr.io/some/otherProject:otherVersionshould allow changing that value, but that doesn't work since theautoPullBaseImagecode only looks in the image buildArg configuration.This PR adds support for looking at all the arg configurations, no matter where they're coming from.