Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix : Jib ignores DOCKER_REGISTRY environment variable (#1617) #1649

Merged
merged 1 commit into from
Feb 28, 2023
Merged

fix : Jib ignores DOCKER_REGISTRY environment variable (#1617) #1649

merged 1 commit into from
Feb 28, 2023

Conversation

rohanKanojia
Copy link
Member

@rohanKanojia rohanKanojia commented Feb 28, 2023 •
edited
Loading

Fix #1617

JibBuildService should check all available registry options before submitting ImageConfiguration to Jib.

Signed-off-by: Rohan Kumar [email protected]

@rohanKanojia
fix : Jib ignores DOCKER_REGISTRY environment variable (fabric8io#1617
fa557e0 
)

JibBuildService should check all available registry options before
submitting ImageConfiguration to Jib.

Signed-off-by: Rohan Kumar <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Feb 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

85.0% 85.0% Coverage
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Merging #1649 (21c8b9f) into master (920fde8) will increase coverage by 0.01%.
The diff coverage is 81.25%.

❗ Current head 21c8b9f differs from pull request most recent head fa557e0. Consider uploading reports for the commit fa557e0 to get more accurate results

@@             Coverage Diff              @@
##             master    #1649      +/-   ##
============================================
+ Coverage     63.84%   63.85%   +0.01%     
- Complexity     2181     2184       +3     
============================================
  Files           170      170              
  Lines          9942     9947       +5     
  Branches       1363     1363              
============================================
+ Hits           6347     6352       +5     
  Misses         3062     3062              
  Partials        533      533
Impacted Files Coverage Δ
...a/io/fabric8/maven/docker/util/JibServiceUtil.java 16.76% <0.00%> (ø)
.../fabric8/maven/docker/service/JibBuildService.java 66.21% <86.66%> (+2.44%) ⬆️

@rohanKanojia rohanKanojia marked this pull request as ready for review February 28, 2023 16:59
@rohanKanojia rohanKanojia merged commit 1c0cc00 into fabric8io:master Feb 28, 2023
@rohanKanojia rohanKanojia deleted the pr/issue1617 branch February 28, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JIB ignores the DOCKER_REGISTRY environment variable
1 participant
@rohanKanojia