Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JIB ignores the DOCKER_REGISTRY environment variable #1617

Closed
johngmyers opened this issue Oct 27, 2022 · 2 comments · Fixed by #1649
Closed

JIB ignores the DOCKER_REGISTRY environment variable #1617

johngmyers opened this issue Oct 27, 2022 · 2 comments · Fixed by #1649
Assignees
@rohanKanojia

Comments

@johngmyers
Copy link

Description

When docker.build.jib is set to true, the docker:push goal ignores the value of the DOCKER_REGISTRY environment variable. It instead tries to push to Docker Hub.

When docker.build.jib is set to false, it correctly pushes to the registry specifed in that environment variable.

Info

  • docker-maven-plugin version : 0.40.2
  • Maven version (mvn -v) : 3.5.0
  • Docker version :
  • If it's a bug, how to reproduce :
  1. Specify the image name without a registry.
  2. Do not specify the <registry> subelement of the <image> configuration.
  3. Do not specify a global configuration element <registry>
  4. Set the DOCKER_REGISTRY environment variable to a registry other than Docker Hub.
  5. Run mvn -Ddocker.build.jib=true docker:build docker:push
@rhuss
Copy link
Collaborator

rhuss commented Feb 14, 2023

Good find, it definitely sounds like a bug. Anyboyd volunteering to look into it ?

@rohanKanojia rohanKanojia self-assigned this Feb 24, 2023
rohanKanojia added a commit to rohanKanojia/docker-maven-plugin that referenced this issue Feb 28, 2023
@rohanKanojia
fix : Jib ignores DOCKER_REGISTRY environment variable (fabric8io#1617
fa557e0 
)

JibBuildService should check all available registry options before
submitting ImageConfiguration to Jib.

Signed-off-by: Rohan Kumar <[email protected]>
@rohanKanojia rohanKanojia mentioned this issue Feb 28, 2023
Merged
rohanKanojia added a commit that referenced this issue Feb 28, 2023
@rohanKanojia
fix : Jib ignores DOCKER_REGISTRY environment variable (#1617)
1c0cc00 
JibBuildService should check all available registry options before
submitting ImageConfiguration to Jib.

Signed-off-by: Rohan Kumar <[email protected]>
@rohanKanojia
Copy link
Member

@johngmyers : Could you please try 0.42.0 to see if it resolves your issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rohanKanojia rohanKanojia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix : Jib ignores DOCKER_REGISTRY environment variable (#1617) rohanKanojia/docker-maven-plugin
3 participants
@rhuss @johngmyers @rohanKanojia