Add support for backpressure to observables. #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,117 @@ | |||
| /* | |||
| * Copyright (C) 2015 Square, Inc. | |||
There was a problem hiding this comment.
This is copy/pasted from square/sqlbrite#35
| final Producer producer = new Producer() { | ||
| @Override public void request(long n) { | ||
| if (n < 0) { | ||
| throw new IllegalArgumentException("requested " + n + " < 0"); |
There was a problem hiding this comment.
Curious, could this ever happen?
There was a problem hiding this comment.
If you accidentally overflow a long (requests usually are Long.MAX_VALUE so you could blindly add 1 and get negative) or are just off-by-one (or more) on some subtraction code for request. But it's unlikely to ever happen in practice. Most of this file is copied from an RxJava operator.
f2prateek
added a commit
that referenced
this pull request
Aug 24, 2015
Add support for backpressure to observables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #26. Forgot about this for v1.0. Not urgent to make another release right away but this will bite people depending on the operators they use with these observables without this change.