Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backpressure is missing #26

Closed
JakeWharton opened this issue Aug 23, 2015 · 1 comment
Closed

Backpressure is missing #26

JakeWharton opened this issue Aug 23, 2015 · 1 comment

Comments

@JakeWharton
Copy link
Contributor

The preference observables do not handle backpressure which will lead to an exception when it's applied aggressively.

Handling backpressure in a system like this is interesting because it should be applied after the filter operator rather than inside of the OnSubscribe. This ensures the pressure is applied to potentially-emitted stream values rather than simply any change to any key. When backpressure is applied and exceeded, values should be dropped and not emitted downstream (like onBackpressureDrop()). When backpressure is let off (i.e., more values are requested) and values were dropped, the operator should immediately emit a single value (the value of which doesn't matter because it's unused) so that the latest preference value is loaded and sent out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant